Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41852 )
Change subject: sb/intel/bd82x6x/smihandler: Fix xHCI sleep handler ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41852/6/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41852/6/src/southbridge/intel/bd82x... PS6, Line 116: if (!smm_points_to_smram((void *)(uintptr_t)xhci_bar)) { Shouldn't this check the actual addresses we are going to read?