Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44631 )
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44631/5/src/mainboard/google/dedede...
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/44631/5/src/mainboard/google/dedede...
PS5, Line 45: config CHROMEOS_WIFI_SAR
: bool "Enable SAR options for Chrome OS build"
: depends on CHROMEOS
: select DSAR_ENABLE
: select GEO_SAR_ENABLE
: select SAR_ENABLE
: select USE_SAR
: select WIFI_SAR_CBFS
GEO_SAR should be project related, maybe separate for each? This will effect the SAR table size.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44631
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic575889fd9b726a710abff78e1ecc8427b668d5d
Gerrit-Change-Number: 44631
Gerrit-PatchSet: 6
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 07 Sep 2020 09:57:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment