Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44631 )
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
mb/google/dedede: Add option to enable WiFi SAR configs
BUG=none TEST=emerge-dedede coreboot
Change-Id: Ic575889fd9b726a710abff78e1ecc8427b668d5d Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/Kconfig 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/44631/1
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index d5057c71..bff54b6 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -41,6 +41,15 @@ select VBOOT_EARLY_EC_SYNC select VBOOT_LID_SWITCH
+config CHROMEOS_WIFI_SAR + bool "Enable SAR options for Chrome OS build" + depends on CHROMEOS + select DSAR_ENABLE + select GEO_SAR_ENABLE + select SAR_ENABLE + select USE_SAR + select WIFI_SAR_CBFS + config DEVICETREE string default "variants/baseboard/devicetree.cb"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44631
to look at the new patch set (#2).
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
mb/google/dedede: Add option to enable WiFi SAR configs
BUG=b:165613510 TEST=emerge-dedede coreboot
Change-Id: Ic575889fd9b726a710abff78e1ecc8427b668d5d Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/Kconfig 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/44631/2
Hello build bot (Jenkins), Henry Sun, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44631
to look at the new patch set (#4).
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
mb/google/dedede: Add option to enable WiFi SAR configs
BUG=b:165613510 TEST=emerge-dedede coreboot
Change-Id: Ic575889fd9b726a710abff78e1ecc8427b668d5d Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/Kconfig 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/44631/4
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44631 )
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
Patch Set 5: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44631 )
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44631/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/44631/5/src/mainboard/google/dedede... PS5, Line 45: config CHROMEOS_WIFI_SAR : bool "Enable SAR options for Chrome OS build" : depends on CHROMEOS : select DSAR_ENABLE : select GEO_SAR_ENABLE : select SAR_ENABLE : select USE_SAR : select WIFI_SAR_CBFS This is more of a note to me that SAR table for Intel WiFi alone resides in CBFS and hence need to be emitted only for that. No action needed from you.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44631 )
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44631/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/44631/5/src/mainboard/google/dedede... PS5, Line 45: config CHROMEOS_WIFI_SAR : bool "Enable SAR options for Chrome OS build" : depends on CHROMEOS : select DSAR_ENABLE : select GEO_SAR_ENABLE : select SAR_ENABLE : select USE_SAR : select WIFI_SAR_CBFS
This is more of a note to me that SAR table for Intel WiFi alone resides in CBFS and hence need to b […]
GEO_SAR should be project related, maybe separate for each? This will effect the SAR table size.
Hello build bot (Jenkins), Henry Sun, Justin TerAvest, Justin TerAvest, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44631
to look at the new patch set (#6).
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
mb/google/dedede: Add option to enable WiFi SAR configs
BUG=b:165613510 TEST=emerge-dedede coreboot
Change-Id: Ic575889fd9b726a710abff78e1ecc8427b668d5d Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/Kconfig 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/44631/6
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44631 )
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
Patch Set 6: Code-Review+2
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44631 )
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44631/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/44631/5/src/mainboard/google/dedede... PS5, Line 45: config CHROMEOS_WIFI_SAR : bool "Enable SAR options for Chrome OS build" : depends on CHROMEOS : select DSAR_ENABLE : select GEO_SAR_ENABLE : select SAR_ENABLE : select USE_SAR : select WIFI_SAR_CBFS
GEO_SAR should be project related, maybe separate for each? This will effect the SAR table size.
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44631 )
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
Patch Set 6: Code-Review+2
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44631 )
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
Patch Set 6:
Hi Karthik/Justin,
Could you help to merge it and cherry-pick to chromeos-2016.05 branch?
Thanks
Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44631 )
Change subject: mb/google/dedede: Add option to enable WiFi SAR configs ......................................................................
mb/google/dedede: Add option to enable WiFi SAR configs
BUG=b:165613510 TEST=emerge-dedede coreboot
Change-Id: Ic575889fd9b726a710abff78e1ecc8427b668d5d Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44631 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/Kconfig 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 2bb255f..f9e2123 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -43,6 +43,14 @@ select VBOOT_EARLY_EC_SYNC select VBOOT_LID_SWITCH
+config CHROMEOS_WIFI_SAR + bool "Enable SAR options for Chrome OS build" + depends on CHROMEOS + select DSAR_ENABLE + select SAR_ENABLE + select USE_SAR + select WIFI_SAR_CBFS + config DEVICETREE string default "variants/baseboard/devicetree.cb"
-
Chen Wisley (Code Review) -
EricR Lai (Code Review)
-
Justin TerAvest (Code Review)
-
Karthik Ramasubramanian (Code Review)