Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45264 )
Change subject: mb/google/zork: Add woomax memory ID 0 ......................................................................
mb/google/zork: Add woomax memory ID 0
Woomax needs memory ID 0 to map to MT40A512M16TB-062E:J.
BUG=b:165611555 TEST=None
Signed-off-by: Rob Barnes robbarnes@google.com Change-Id: Ibbcef6be382bd6649c93cfe92427f124dd137112 --- M src/mainboard/google/zork/variants/woomax/spd/Makefile.inc M src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/45264/1
diff --git a/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc b/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc index dd877fd..91ef5e5 100644 --- a/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc @@ -2,7 +2,7 @@ ## This is an auto-generated file. Do not edit!!
SPD_SOURCES = -SPD_SOURCES += ddr4-spd-empty.hex # ID = 0(0b0000) +SPD_SOURCES += ddr4-spd-1.hex # ID = 0(0b0000) Parts = MT40A512M16TB-062E:J SPD_SOURCES += ddr4-spd-1.hex # ID = 1(0b0001) Parts = H5AN8G6NCJR-XNC SPD_SOURCES += ddr4-spd-empty.hex # ID = 2(0b0010) SPD_SOURCES += ddr4-spd-empty.hex # ID = 3(0b0011) diff --git a/src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt index 7d40e2a..c0583f4 100644 --- a/src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt @@ -1,4 +1,5 @@ DRAM Part Name ID to assign +MT40A512M16TB-062E:J 0 (0000) H5AN8G6NCJR-XNC 1 (0001) MT40A512M16TB-062E:J 8 (1000) H5AN8G6NCJR-XNC 9 (1001) diff --git a/src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt index 625a8d0..65988e9 100644 --- a/src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt @@ -7,6 +7,7 @@ # See util/spd_tools/ddr4/README.md for more details and instructions.
# Part Name, Fixed ID (optional) +MT40A512M16TB-062E:J, 0 H5AN8G6NCJR-XNC, 1 MT40A512M16TB-062E:J, 8 H5AN8G6NCJR-XNC, 9
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45264 )
Change subject: mb/google/zork: Add woomax memory ID 0 ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45264 )
Change subject: mb/google/zork: Add woomax memory ID 0 ......................................................................
mb/google/zork: Add woomax memory ID 0
Woomax needs memory ID 0 to map to MT40A512M16TB-062E:J.
BUG=b:165611555 TEST=None
Signed-off-by: Rob Barnes robbarnes@google.com Change-Id: Ibbcef6be382bd6649c93cfe92427f124dd137112 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45264 Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/woomax/spd/Makefile.inc M src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc b/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc index dd877fd..91ef5e5 100644 --- a/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc @@ -2,7 +2,7 @@ ## This is an auto-generated file. Do not edit!!
SPD_SOURCES = -SPD_SOURCES += ddr4-spd-empty.hex # ID = 0(0b0000) +SPD_SOURCES += ddr4-spd-1.hex # ID = 0(0b0000) Parts = MT40A512M16TB-062E:J SPD_SOURCES += ddr4-spd-1.hex # ID = 1(0b0001) Parts = H5AN8G6NCJR-XNC SPD_SOURCES += ddr4-spd-empty.hex # ID = 2(0b0010) SPD_SOURCES += ddr4-spd-empty.hex # ID = 3(0b0011) diff --git a/src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt index 7d40e2a..c0583f4 100644 --- a/src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt @@ -1,4 +1,5 @@ DRAM Part Name ID to assign +MT40A512M16TB-062E:J 0 (0000) H5AN8G6NCJR-XNC 1 (0001) MT40A512M16TB-062E:J 8 (1000) H5AN8G6NCJR-XNC 9 (1001) diff --git a/src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt index 625a8d0..65988e9 100644 --- a/src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt @@ -7,6 +7,7 @@ # See util/spd_tools/ddr4/README.md for more details and instructions.
# Part Name, Fixed ID (optional) +MT40A512M16TB-062E:J, 0 H5AN8G6NCJR-XNC, 1 MT40A512M16TB-062E:J, 8 H5AN8G6NCJR-XNC, 9
-
Aaron Durbin (Code Review) -
Martin Roth (Code Review)
-
Rob Barnes (Code Review)