[coreboot-gerrit] Change in coreboot[master]: soc/amd/common/block/spi: Add support for common SPI configuration

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41248 )

Change subject: soc/amd/common/block/spi: Add support for common SPI configuration
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41248/6/src/soc/amd/common/block/sp... 
File src/soc/amd/common/block/spi/fch_spi.c:

https://review.coreboot.org/c/coreboot/+/41248/6/src/soc/amd/common/block/sp... 
PS6, Line 22: 	lpc_enable_spi_rom(SPI_ROM_ENABLE);
> As a cleanup, we should move this out of this function. […]

Agreed. Probably a devicetree config option here would be helpful.