[coreboot-gerrit] Change in coreboot[master]: mb/acer: Add Acer Aspire VN7-572G

[Benjamin Doron (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Matt DeVillier, Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35523

to look at the new patch set (#77).

Change subject: mb/acer: Add Acer Aspire VN7-572G
......................................................................

mb/acer: Add Acer Aspire VN7-572G

Add initial support for Acer Aspire VN7-572G.

Works:
- Booting Fedora 31 using TianoCore (CorebootPayload)
- Display
  - with FSP GOP + KBL VBT
- Keyboard and touchpad
  - Neither can seem to wake device from S3?
  - Small touchpad nits
  - (Perhaps fixed with I2C HID devices declared in devicetree)
- USB ports (unable to test type-C)
- HDMI port
- Internal and HDMI audio

Requires testing:
- Display
  - with libgfxinit
  - with FSP GOP + a customised KBL VBT, to match vendor's configuration

Does not work:
- dGPU (GPIO sequence matches Optimus)
- Headphone jack and microphone
- S3 only works with hotkey (and cannot be resumed from)

ACPI:
- EC is not functioning normally
  - AC and battery devices appear
  - Device detected as being perpetually connected to AC
  - Lid "not compliant to SW_LID"
- Brightness "Fn" keys not working (requires graphics.asl, which
requires implementation of GMA for Skylake)

Bugs:
- "pcieport 0000:00:1d.1:
AER: PCIe Bus Error: severity=Corrected, type=Data Link Layer,
(Transmitter ID)
AER:   device [8086:9d19] error status/mask=00001000/00002000
AER:    [12] Timeout"
  - Fixed by setting ASPM policy in Linux to performance, disabling substates
- "[ ..snip ..]ata2.00: failed command: WRITE FPDMA QUEUED[ ..snip ..]"

Unknown:
- TPM

Change-Id: I6340116abfeb2fbd280d143b74d323e4da3566f6
Signed-off-by: Benjamin Doron 
---
A src/mainboard/acer/Kconfig
A src/mainboard/acer/Kconfig.name
A src/mainboard/acer/aspire_vn7_572g/Kconfig
A src/mainboard/acer/aspire_vn7_572g/Kconfig.name
A src/mainboard/acer/aspire_vn7_572g/Makefile.inc
A src/mainboard/acer/aspire_vn7_572g/acpi/brightness_levels.asl
A src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl
A src/mainboard/acer/aspire_vn7_572g/acpi/graphics.asl
A src/mainboard/acer/aspire_vn7_572g/acpi/mainboard.asl
A src/mainboard/acer/aspire_vn7_572g/acpi/platform.asl
A src/mainboard/acer/aspire_vn7_572g/acpi/superio.asl
A src/mainboard/acer/aspire_vn7_572g/board_info.txt
A src/mainboard/acer/aspire_vn7_572g/devicetree.cb
A src/mainboard/acer/aspire_vn7_572g/dsdt.asl
A src/mainboard/acer/aspire_vn7_572g/gma-mainboard.ads
A src/mainboard/acer/aspire_vn7_572g/gpio.h
A src/mainboard/acer/aspire_vn7_572g/hda_verb.c
A src/mainboard/acer/aspire_vn7_572g/ramstage.c
A src/mainboard/acer/aspire_vn7_572g/romstage.c
19 files changed, 2,144 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35523/77