Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33621 )
Change subject: soc/amd/stoneyridge: Add merlinfalcon configuration
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/33621/2/src/soc/amd/stoneyridge/Makefile.inc
File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/#/c/33621/2/src/soc/amd/stoneyridge/Makefile.inc...
PS2, Line 146: MF
BTW you might want to force the FILE_ variables for the fanless SKUs to be empty assignments. […]
I figured out a different way, with
ifeq ($(CONFIG_SOC_AMD_PSP_SELECTABLE_SMU_FW),y)
https://review.coreboot.org/#/c/33621/2/src/soc/amd/stoneyridge/Makefile.inc...
PS2, Line 239: ifeq ($(CONFIG_SOC_AMD_MERLINFALCON_FP4),y)
Somewhere above, add a variable assignment that depends on the device, e.g. […]
Seems to work, thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33621
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9f960b8f012c5a1cfd398611d6a51838493da27
Gerrit-Change-Number: 33621
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Charles Marslett
charles.marslett@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 25 Jun 2019 22:07:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment