Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37582 )
Change subject: intel/fsp2_0: Make FSP_USE_REPO a SoC opt-in ......................................................................
Patch Set 10:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37582/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37582/5//COMMIT_MSG@15 PS5, Line 15: All other interactions with FSP_USE_REPO stay the same.
Please add exactly one blank line between paragraphs.
Done
https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/Kconfig File src/soc/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/Kconfig@53 PS6, Line 53: "Use FSP Blobs from fsp submodule"
This shouldn't have a prompt
Done
https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/Kconfig@55 PS6, Line 55: This SOC has FSP binaries living in 3rdparty/fsp.
How about: […]
Done
https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/cannonlake/Kc... File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/cannonlake/Kc... PS6, Line 68: select HAVE_INTEL_FSP_REPO
Not sure if CannonLake just uses the CoffeeLake FSP package, or if it is not supported at all
Can't tell, but I would go with `if !SOC_INTEL_CANNONLAKE` since `FSP_FD_PATH` has no default value for it.
https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/xeon_sp/Kconf... File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/xeon_sp/Kconf... PS6, Line 41: select HAVE_INTEL_FSP_REPO
Um, I don't think so.
Done