5 comments:
Patch Set #5, Line 15: All other interactions with FSP_USE_REPO stay the same.
Please add exactly one blank line between paragraphs.
Done
Patch Set #6, Line 53: "Use FSP Blobs from fsp submodule"
This shouldn't have a prompt
Done
Patch Set #6, Line 55: This SOC has FSP binaries living in 3rdparty/fsp.
How about: […]
Done
File src/soc/intel/cannonlake/Kconfig:
Patch Set #6, Line 68: select HAVE_INTEL_FSP_REPO
Not sure if CannonLake just uses the CoffeeLake FSP package, or if it is not supported at all
Can't tell, but I would go with `if !SOC_INTEL_CANNONLAKE` since `FSP_FD_PATH` has no default value for it.
File src/soc/intel/xeon_sp/Kconfig:
Patch Set #6, Line 41: select HAVE_INTEL_FSP_REPO
Um, I don't think so.
Done
To view, visit change 37582. To unsubscribe, or for help writing mail filters, visit settings.