Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47292 )
Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47292/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47292/2//COMMIT_MSG@9 PS2, Line 9: Per elan request, change to level trigger to fix touchscreen function lost Can you please add the following detail to the commit message:
ELAN touchscreen device used on drawcia is I2C-HID device and as per "HID over I2C Protocol Specification"[1] Version 1.00 Section 7.4, the interrupt line used by the device is expected to be level triggered. Hence, this change updates the configuration of the touchscreen interrupt to be level triggered.
References: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d...
https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... PS2, Line 202: ACPI_IRQ_LEVEL_LOW
Elan uploaded doc in tracker. It use level trigger in "ACPI Setting Reference" page.
Thanks for the reference Wisley! Can you please update the commit message as per the comment provided? Thanks!