Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32653 )
Change subject: soc/amd/stoneyridge: Move LPC support to common ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/#/c/32653/4/src/soc/amd/common/block/lpc/lpc.c File src/soc/amd/common/block/lpc/lpc.c:
https://review.coreboot.org/#/c/32653/4/src/soc/amd/common/block/lpc/lpc.c@3... PS4, Line 38: late_lpc_bridge_enable
If a function is supposed to be implemented by the SoC, it would be helpful to add _soc_ in its name […]
Done
https://review.coreboot.org/#/c/32653/4/src/soc/amd/common/block/lpc/lpc_uti... File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/#/c/32653/4/src/soc/amd/common/block/lpc/lpc_uti... PS4, Line 36: struct
const
Done
https://review.coreboot.org/#/c/32653/4/src/soc/amd/common/block/lpc/lpc_uti... PS4, Line 40: TOTAL_WIDEIO_PORTS
Is this something that the SoC is supposed to provide? If this is always going to be 3, do we really […]
It looks like that went in here https://review.coreboot.org/c/coreboot/+/22590, and I'd guess it was to make walking the array easier. However, I looked at a handful of BKDGs and docs for discrete FCHs, and I'm comfortable that it hasn't changed.
https://review.coreboot.org/#/c/32653/4/src/soc/amd/common/block/lpc/lpc_uti... PS4, Line 188: (uintptr_t)
Is this typecast necessary?
Done