4 comments:
File src/soc/amd/common/block/lpc/lpc.c:
Patch Set #4, Line 38: late_lpc_bridge_enable
If a function is supposed to be implemented by the SoC, it would be helpful to add _soc_ in its name […]
Done
File src/soc/amd/common/block/lpc/lpc_util.c:
Patch Set #4, Line 36: struct
const
Done
Patch Set #4, Line 40: TOTAL_WIDEIO_PORTS
Is this something that the SoC is supposed to provide? If this is always going to be 3, do we really […]
It looks like that went in here https://review.coreboot.org/c/coreboot/+/22590, and I'd guess it was to make walking the array easier. However, I looked at a handful of BKDGs and docs for discrete FCHs, and I'm comfortable that it hasn't changed.
Patch Set #4, Line 188: (uintptr_t)
Is this typecast necessary?
Done
To view, visit change 32653. To unsubscribe, or for help writing mail filters, visit settings.