Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35730 )
Change subject: sb,nb/intel/fsp_rangeley: Rename from xx_DEV_FUNC
......................................................................
Patch Set 1:
Patch Set 1:
Hi,
I presume you have a reason for doing this but I'm confused about the purpose of making these changes.
From a functional perspective this change is fine but why do this?
Conventions and consitency with naming helps. We are currently evaluating ways to replace some/most/lot of pci_devfn_t with struct device *, and potentially auto-generating these _DEVFN_ from devicetree.cb where necessary.
The prefix XXX_ is arbitrary. Would SCH_ or PCH_ be somewhat correct?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35730
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ead2bc5e41a86c9aeef730f5664a30406414c8c
Gerrit-Change-Number: 35730
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Guckian
Gerrit-Comment-Date: Tue, 01 Oct 2019 02:03:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment