[coreboot-gerrit] Change in coreboot[master]: soc/intel: Use config_of_path(SA_DEVFN_ROOT)

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34299 )

Change subject: soc/intel: Use config_of_path(SA_DEVFN_ROOT)
......................................................................

Patch Set 4:

(1 comment)

Jacob, Elyes : Is one of you regularly running clang static analyzer passed?

I wonder if it goes wild on this commit. My attempt here is to use __noreturn pcidev_die() called from inlined function. Is that enough / not required at all, to convince config_of() never returns with NULL.

https://review.coreboot.org/c/coreboot/+/34299/4/src/soc/intel/apollolake/ac... 
File src/soc/intel/apollolake/acpi.c:

https://review.coreboot.org/c/coreboot/+/34299/4/src/soc/intel/apollolake/ac... 
PS4, Line 172: cfg
> If cfg was NULL, control would never reach here.

Right, I think there are more cases than the two you have spotted.