[coreboot-gerrit] [S] Change in coreboot[master]: drivers/ocp/dmi: Fix smbios type 11 get wrong ppin value for second s...

[Angel Pons (Code Review)]

Attention is currently required from: Jonathan Zhang, Shuming Chu (Shuming), Arthur Heymans, TangYiwei.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68910 )

Change subject: drivers/ocp/dmi: Fix smbios type 11 get wrong ppin value for second socket
......................................................................

Patch Set 4: Code-Review+1

(2 comments)

File src/drivers/ocp/dmi/smbios.c:

https://review.coreboot.org/c/coreboot/+/68910/comment/73460a93_c672688e 
PS4, Line 259: 				get_logic_cpu(1), 100 * USECS_PER_MSEC) !=
> what if the return value of get_logic_cpu() is -1?

Looks like it wouldn't do anything, but it would be wise to add a check.

https://review.coreboot.org/c/coreboot/+/68910/comment/085b494f_473135d8 
PS4, Line 264: /* Wait for read_remote_ppin() to finish because it's executed
             : 			   in parallel */
For another patch: There's the `mp_run_on_aps_and_wait_for_complete()` function.