Attention is currently required from: Jonathan Zhang, Shuming Chu (Shuming), Arthur Heymans, TangYiwei.

Patch set 4:Code-Review +1

View Change

2 comments:

• File src/drivers/ocp/dmi/smbios.c:

  • Patch Set #4, Line 259: get_logic_cpu(1), 100 * USECS_PER_MSEC) !=

    what if the return value of get_logic_cpu() is -1?

    Looks like it wouldn't do anything, but it would be wise to add a check.

  • Patch Set #4, Line 264:

    /* Wait for read_remote_ppin() to finish because it's executed
    			   in parallel */
    

    For another patch: There's the `mp_run_on_aps_and_wait_for_complete()` function.

To view, visit change 68910. To unsubscribe, or for help writing mail filters, visit settings.