Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38549 )
Change subject: Add support for OCP platform TiogaPass ......................................................................
Patch Set 5:
(7 comments)
Thanks for the review. Will update an updated patch set over the weekend.
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@7 PS4, Line 7: Add support for OCP platform TiogaPass
Please add a prefix.
Done
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@9 PS4, Line 9: 2 socket
this works as an adjective, so it should be hyphenated: 2-socket
Done
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@9 PS4, Line 9: platform based on : Intel Skylake-SP SOC. The chipset includes Lewisburg PCH.
I would rewrite this part a bit: […]
Done
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@15 PS4, Line 15: was
is
Done
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@17 PS4, Line 17: ifconfig
ip is the successor.
Done
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@22 PS4, Line 22: does
do
Done
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@24 PS4, Line 24: 3. "lspci -vvv" causes segmentation fault.
Really? Should be documented more elaborately.
Actually after I flashed in traditional UEFI firmware, the same problem happens. This might has something to do with target OS kernel, which is quite old (4.16.0). So I am removing this as a known issue.