Thanks for the review. Will update an updated patch set over the weekend.
View Change
7 comments:
Commit Message:
Patch Set #4, Line 7: Add support for OCP platform TiogaPass
Please add a prefix.
Done
Patch Set #4, Line 9: 2 socket
this works as an adjective, so it should be hyphenated: 2-socket
Done
Patch Set #4, Line 9:
platform based on
Intel Skylake-SP SOC. The chipset includes Lewisburg PCH.
I would rewrite this part a bit: […]
Done
Patch Set #4, Line 15: was
is
Done
Patch Set #4, Line 17: ifconfig
ip is the successor.
Done
Patch Set #4, Line 22: does
do
Done
Patch Set #4, Line 24: 3. "lspci -vvv" causes segmentation fault.
Really? Should be documented more elaborately.
Actually after I flashed in traditional UEFI firmware, the same problem happens. This might has something to do with target OS kernel, which is quite old (4.16.0). So I am removing this as a known issue.
To view, visit change 38549. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29868f03037d1887b90dfb19d15aee83c456edce
Gerrit-Change-Number: 38549
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Andrey Petrov <anpetrov@fb.com>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 24 Jan 2020 23:09:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment