Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41918 )
Change subject: abuild: Fix board variant handling ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Patch Set 1:
If we don't want to land this patch, we will have to put out a full "Documentation" [1] on abuild that we have to use this format:
eg. to build test asus/p5qpl-am/variants/p5g41t-m_lx/, one has to run: $ util/abuild/abuild -t asus/p5qpl-am -b p5g41t_m_lx
Meanwhile substitution underscores for dashes for base target like p5qpl_am does not work.
[1] Yes, I mean add full documentation under Documentation/
What if a mainboard uses a non-matching Kconfig symbol? For example, the names I fixed in CB:38083
Then we have to go by Kconfig symbol only (CONFIG_BOARD_xxx_yyy etc.), which would also (in theory) work with non-standard tree structures. Case in point: My earlier efforts to convert the entire asus/p2b family was done without variants/ directory with everything set up via Kconfig and Makefile.inc. That version has to be abandoned because it doesn't work with abuild.