Patch Set 1: Code-Review+1

Patch Set 1:

If we don't want to land this patch, we will have to put out a full "Documentation" [1] on abuild that we have to use this format:

eg. to build test asus/p5qpl-am/variants/p5g41t-m_lx/, one has to run:
$ util/abuild/abuild -t asus/p5qpl-am -b p5g41t_m_lx

Meanwhile substitution underscores for dashes for base target like p5qpl_am does not work.

[1] Yes, I mean add full documentation under Documentation/

What if a mainboard uses a non-matching Kconfig symbol? For example, the names I fixed in CB:38083

Then we have to go by Kconfig symbol only (CONFIG_BOARD_xxx_yyy etc.), which would also (in theory) work with non-standard tree structures. Case in point: My earlier efforts to convert the entire asus/p2b family was done without variants/ directory with everything set up via Kconfig and Makefile.inc. That version has to be abandoned because it doesn't work with abuild.

View Change

To view, visit change 41918. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10d5b471dac41c50a85c4a309ec561b02687bb9a
Gerrit-Change-Number: 41918
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui <buurin@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 02 Jun 2020 18:22:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment