[coreboot-gerrit] Change in coreboot[master]: cbfs: store header offset as absolute value BE from fmap_top

[Marty E. Plummer (Code Review)]

Marty E. Plummer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36346 )

Change subject: cbfs: store header offset as absolute value BE from fmap_top
......................................................................

Patch Set 1:
> Patch Set 1:
>
> Hmm... well, if you really need this to be well-defined, can we define it to always be little-endian? That wouldn't break existing readers.

Well, as you mentioned, there is the consistency issue, and to be frank I am
not aware of any things other than src/lib/cbfs.c which look at this particular
offset. I could be wrong but I think the others just look at the header it
points to.