Patch Set 1:

Hmm... well, if you really need this to be well-defined, can we define it to always be little-endian? That wouldn't break existing readers.

Well, as you mentioned, there is the consistency issue, and to be frank I am
not aware of any things other than src/lib/cbfs.c which look at this particular
offset. I could be wrong but I think the others just look at the header it
points to.

View Change

To view, visit change 36346. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc99b0c133faa2aa15d06f998e7371d332ffa490
Gerrit-Change-Number: 36346
Gerrit-PatchSet: 1
Gerrit-Owner: Marty E. Plummer <hanetzer@startmail.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Marty E. Plummer <hanetzer@startmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sat, 26 Oct 2019 01:02:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment