[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Add support for CSE IOM/NPHY sub-parition update

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Julius Werner, Krishna P Bhat D.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59685 )

Change subject: soc/intel/common: Add support for CSE IOM/NPHY sub-parition update
......................................................................

Patch Set 18: Code-Review+2

(2 comments)

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/59685/comment/d636c43a_fb10d205 
PS16, Line 405: 
              : __weak bool skip_cse_sub_part_update(void)
              : {
              : 	return false;
              : }
> Done

Well, honestly I have no idea if we'll come across this case again, but I wouldn't be surprised.

https://review.coreboot.org/c/coreboot/+/59685/comment/a7e0ad77_eaec29a2 
PS16, Line 805:
> When fmap_locate_area_as_rdev_rw() is used to get the target region device, there is no mmap/munmap  […]

Oh that's true, you only get mmap on the ro device.

I guess you could refactor this so they can still share the fw_ver->{major,minor...} lines, but that seems not particularly worth it here.