Change in coreboot[master]: soc/intel/common: Add support for CSE IOM/NPHY sub-parition update

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Julius Werner, Krishna P Bhat D.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59685 )

Change subject: soc/intel/common: Add support for CSE IOM/NPHY sub-parition update
......................................................................


Patch Set 18: Code-Review+2

(2 comments)

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/59685/comment/d636c43a_fb10d205 
PS16, Line 405: 
              : __weak bool skip_cse_sub_part_update(void)
              : {
              : 	return false;
              : }
> Done
> Well, honestly I have no idea if we'll come across this case again, but I wouldn't be surprised.

https://review.coreboot.org/c/coreboot/+/59685/comment/a7e0ad77_eaec29a2 
PS16, Line 805:
> When fmap_locate_area_as_rdev_rw() is used to get the target region device, there is no mmap/munmap  […]
> Oh that's true, you only get mmap on the ro device.

I guess you could refactor this so they can still share the fw_ver->{major,minor...} lines, but that seems not particularly worth it here.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c0cda51314c4f722f5432486a43e19b46f4b240
Gerrit-Change-Number: 59685
Gerrit-PatchSet: 18
Gerrit-Owner: Krishna P Bhat D <[e-mail]>
Gerrit-Reviewer: Balaji Manigandan <[e-mail]>
Gerrit-Reviewer: Kane Chen <[e-mail]>
Gerrit-Reviewer: Marx Wang <[e-mail]>
Gerrit-Reviewer: Nick Vaccaro <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Rizwan Qureshi <[e-mail]>
Gerrit-Reviewer: Sridhar Siricilla <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Anfernee Chen <[e-mail]>
Gerrit-CC: Julius Werner <[e-mail]>
Gerrit-CC: Mark Hsieh <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Julius Werner <[e-mail]>
Gerrit-Attention: Krishna P Bhat D <[e-mail]>
Gerrit-Comment-Date: Fri, 03 Dec 2021 17:36:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak <[e-mail]>
Comment-In-Reply-To: Julius Werner <[e-mail]>
Comment-In-Reply-To: Krishna P Bhat D <[e-mail]>
Gerrit-MessageType: comment