Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40587 )
Change subject: mb/google/dedede: add new variant for wheelie ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG@7 PS6, Line 7: wheelie
dedede
Done
https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG@15 PS6, Line 15: Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com
Nit: Move it after Change-Id line.
Done
https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/dedede... PS6, Line 81: Wheelie
wheelie
Done
https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/wheelie/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/dedede... PS6, Line 1: chip soc/intel/jasperlake
Define this as well, so that the I2C rise, hold and fall times can be tuned later. […]
Done