Change in coreboot[master]: mb/google/wheelie: add new variant for wheelie

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Peichao Li (Code Review)

22 Apr 2020 22 Apr '20

12:55 a.m.

Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... mb/google/wheelie: add new variant for wheelie Add initial support for wheelie variant board. BUG=b:154664137 BRANCH=None TEST=build Signed-off-by: peichao.wang <peichao.wang(a)bitland.corp-partner.google.com> Change-Id: Id638e987f45c247dae824f221a38ccf32626572f --- A src/mainboard/google/dedede/variants/wheelie/Makefile.inc A src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h A src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h A src/mainboard/google/dedede/variants/wheelie/overridetree.cb 4 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/40587/1 diff --git a/src/mainboard/google/dedede/variants/wheelie/Makefile.inc b/src/mainboard/google/dedede/variants/wheelie/Makefile.inc new file mode 100644 index 0000000..13afb36 --- /dev/null +++ b/src/mainboard/google/dedede/variants/wheelie/Makefile.inc @@ -0,0 +1,8 @@ +## +## This file is part of the coreboot project. +## +## +## SPDX-License-Identifier: GPL-2.0-or-later +## + +SPD_SOURCES = Micron_MT53E512M32D2NP_2GB #0b0000 diff --git a/src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h b/src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h new file mode 100644 index 0000000..70bd8e7 --- /dev/null +++ b/src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h @@ -0,0 +1,13 @@ +/* + * This file is part of the coreboot project. + * + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef MAINBOARD_EC_H +#define MAINBOARD_EC_H + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h b/src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h new file mode 100644 index 0000000..fd92743 --- /dev/null +++ b/src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h @@ -0,0 +1,13 @@ +/* + * This file is part of the coreboot project. + * + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef MAINBOARD_GPIO_H +#define MAINBOARD_GPIO_H + +#include <baseboard/gpio.h> + +#endif /* MAINBOARD_GPIO_H */ diff --git a/src/mainboard/google/dedede/variants/wheelie/overridetree.cb b/src/mainboard/google/dedede/variants/wheelie/overridetree.cb new file mode 100644 index 0000000..75ef7f7 --- /dev/null +++ b/src/mainboard/google/dedede/variants/wheelie/overridetree.cb @@ -0,0 +1 @@ +chip soc/intel/jasperlake -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-MessageType: newchange

Attachments:

attachment.htm (text/html — 5.9 KB)

Show replies by date

Peichao Li (Code Review)

22 Apr 22 Apr

12:57 a.m.

Peichao Li has removed Patrick Georgi from this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Removed reviewer Patrick Georgi. -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-CC: Magf - <magf(a)bitland.corp-partner.google.com> Gerrit-MessageType: deleteReviewer

Peichao Li (Code Review)

12:57 a.m.

Peichao Li has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Removed reviewer Martin Roth. -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-CC: Magf - <magf(a)bitland.corp-partner.google.com> Gerrit-MessageType: deleteReviewer

Peichao Li (Code Review)

12:57 a.m.

Peichao Li has removed Furquan Shaikh from this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Removed reviewer Furquan Shaikh. -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-CC: Magf - <magf(a)bitland.corp-partner.google.com> Gerrit-MessageType: deleteReviewer

Peichao Li (Code Review)

12:57 a.m.

Peichao Li has removed Justin TerAvest from this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Removed reviewer Justin TerAvest. -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-CC: Magf - <magf(a)bitland.corp-partner.google.com> Gerrit-MessageType: deleteReviewer

Peichao Li (Code Review)

12:57 a.m.

Peichao Li has removed Marco Chen from this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Removed reviewer Marco Chen. -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-CC: Magf - <magf(a)bitland.corp-partner.google.com> Gerrit-MessageType: deleteReviewer

Peichao Li (Code Review)

12:57 a.m.

Peichao Li has removed Magf - from this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Removed reviewer Magf -. -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-MessageType: deleteReviewer

Marco Chen (Code Review)

1 a.m.

Peichao Li (Code Review)

1:01 a.m.

Hello Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40587 to look at the new patch set (#2). Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... mb/google/wheelie: add new variant for wheelie Add initial support for wheelie variant board. BUG=b:154664137 BRANCH=None TEST=build Signed-off-by: peichao.wang <peichao.wang(a)bitland.corp-partner.google.com> Change-Id: Id638e987f45c247dae824f221a38ccf32626572f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/wheelie/Makefile.inc A src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h A src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h A src/mainboard/google/dedede/variants/wheelie/overridetree.cb 6 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/40587/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Marco Chen <marcochen(a)google.com> Gerrit-MessageType: newpatchset

Marco Chen (Code Review)

1:02 a.m.

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/40587/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40587/1//COMMIT_MSG@7 PS1, Line 7: wheelie dedede -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Apr 2020 06:02:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Marco Chen (Code Review)

1:03 a.m.

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/40587/2/src/mainboard/google/deded… File src/mainboard/google/dedede/Kconfig.name: https://review.coreboot.org/c/coreboot/+/40587/2/src/mainboard/google/deded… PS2, Line 25: select BOARD_ROMSIZE_KB_32768 nit: tab instead of spaces -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Apr 2020 06:03:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

1:11 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: add new variant for wheelie

Hello Furquan Shaikh, Patrick Georgi, Martin Roth, Justin TerAvest, Marco Chen, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40587 to look at the new patch set (#3). Change subject: mb/google/dedede: add new variant for wheelie ...................................................................... mb/google/dedede: add new variant for wheelie Add initial support for wheelie variant board. BUG=b:154664137 BRANCH=None TEST=build Signed-off-by: peichao.wang <peichao.wang(a)bitland.corp-partner.google.com> Change-Id: Id638e987f45c247dae824f221a38ccf32626572f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/wheelie/Makefile.inc A src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h A src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h A src/mainboard/google/dedede/variants/wheelie/overridetree.cb 6 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/40587/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 3 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

Peichao Li (Code Review)

1:13 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Justin TerAvest, Marco Chen, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40587 to look at the new patch set (#4). Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... mb/google/wheelie: add new variant for wheelie Add initial support for wheelie variant board. BUG=b:154664137 BRANCH=None TEST=build Signed-off-by: peichao.wang <peichao.wang(a)bitland.corp-partner.google.com> Change-Id: Id638e987f45c247dae824f221a38ccf32626572f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/wheelie/Makefile.inc A src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h A src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h A src/mainboard/google/dedede/variants/wheelie/overridetree.cb 6 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/40587/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 4 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

Peichao Li (Code Review)

1:14 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/40587/2/src/mainboard/google/deded… File src/mainboard/google/dedede/Kconfig.name: https://review.coreboot.org/c/coreboot/+/40587/2/src/mainboard/google/deded… PS2, Line 25: select BOARD_ROMSIZE_KB_32768

...

nit: tab instead of spaces

Dear Marco, done. -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 4 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Apr 2020 06:14:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marco Chen <marcochen(a)google.com> Gerrit-MessageType: comment

Peichao Li (Code Review)

1:14 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: add new variant for wheelie

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Justin TerAvest, Marco Chen, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40587 to look at the new patch set (#5). Change subject: mb/google/dedede: add new variant for wheelie ...................................................................... mb/google/dedede: add new variant for wheelie Add initial support for wheelie variant board. BUG=b:154664137 BRANCH=None TEST=build Signed-off-by: peichao.wang <peichao.wang(a)bitland.corp-partner.google.com> Change-Id: Id638e987f45c247dae824f221a38ccf32626572f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/wheelie/Makefile.inc A src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h A src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h A src/mainboard/google/dedede/variants/wheelie/overridetree.cb 6 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/40587/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 5 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

Peichao Li (Code Review)

1:32 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Justin TerAvest, Marco Chen, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40587 to look at the new patch set (#6). Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... mb/google/wheelie: add new variant for wheelie Add initial support for wheelie variant board. BUG=b:154664137 BRANCH=None TEST=build Signed-off-by: peichao.wang <peichao.wang(a)bitland.corp-partner.google.com> Change-Id: Id638e987f45c247dae824f221a38ccf32626572f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/wheelie/Makefile.inc A src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h A src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h A src/mainboard/google/dedede/variants/wheelie/overridetree.cb 6 files changed, 45 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/40587/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 6 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

Peichao Li (Code Review)

2:39 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Patch Set 6: (2 comments) https://review.coreboot.org/c/coreboot/+/40587/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40587/1//COMMIT_MSG@7 PS1, Line 7: wheelie

...

dedede

Done https://review.coreboot.org/c/coreboot/+/40587/2/src/mainboard/google/deded… File src/mainboard/google/dedede/Kconfig.name: https://review.coreboot.org/c/coreboot/+/40587/2/src/mainboard/google/deded… PS2, Line 25: select BOARD_ROMSIZE_KB_32768

...

Dear Marco, done.

Done -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 6 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Apr 2020 07:39:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marco Chen <marcochen(a)google.com> Comment-In-Reply-To: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-MessageType: comment

Marco Chen (Code Review)

4:08 a.m.

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/deded… File src/mainboard/google/dedede/Kconfig: https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/deded… PS6, Line 81: Wheelie wheelie -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 6 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Apr 2020 09:08:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

2:21 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Patch Set 6: (3 comments) https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG@7 PS6, Line 7: wheelie dedede https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG@15 PS6, Line 15: Signed-off-by: peichao.wang <peichao.wang(a)bitland.corp-partner.google.com> Nit: Move it after Change-Id line. https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/deded… File src/mainboard/google/dedede/variants/wheelie/overridetree.cb: https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/deded… PS6, Line 1: chip soc/intel/jasperlake Define this as well, so that the I2C rise, hold and fall times can be tuned later. # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | #+-------------------+---------------------------+ #| GSPI0 | cr50 TPM. Early init is | #| | required to set up a BAR | #| | for TPM communication | #| | before memory is up | #| I2C0 | Trackpad | #| I2C1 | Digitizer | #| I2C2 | Touchscreen | #| I2C3 | Camera | #| I2C4 | Audio | #+-------------------+---------------------------+ register "common_soc_config" = "{ .gspi[0] = { .speed_mhz = 1, .early_init = 1, }, .i2c[0] = { .speed = I2C_SPEED_FAST, }, .i2c[1] = { .speed = I2C_SPEED_FAST, }, .i2c[2] = { .speed = I2C_SPEED_FAST, }, .i2c[3] = { .speed = I2C_SPEED_FAST, }, .i2c[4] = { .speed = I2C_SPEED_FAST, }, }" -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 6 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Apr 2020 19:21:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

7:42 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: add new variant for wheelie

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Justin TerAvest, Marco Chen, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40587 to look at the new patch set (#7). Change subject: mb/google/dedede: add new variant for wheelie ...................................................................... mb/google/dedede: add new variant for wheelie Add initial support for wheelie variant board. BUG=b:154664137 BRANCH=None TEST=build Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Signed-off-by: peichao.wang <peichao.wang(a)bitland.corp-partner.google.com> --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/wheelie/Makefile.inc A src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h A src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h A src/mainboard/google/dedede/variants/wheelie/overridetree.cb 6 files changed, 81 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/40587/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 7 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

Peichao Li (Code Review)

23 Apr 23 Apr

1:38 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: add new variant for wheelie

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/dedede: add new variant for wheelie ...................................................................... Patch Set 7: (4 comments) https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG@7 PS6, Line 7: wheelie

...

dedede

Done https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG@15 PS6, Line 15: Signed-off-by: peichao.wang <peichao.wang(a)bitland.corp-partner.google.com>

...

Nit: Move it after Change-Id line.

Done https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/deded… File src/mainboard/google/dedede/Kconfig: https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/deded… PS6, Line 81: Wheelie

...

wheelie

Done https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/deded… File src/mainboard/google/dedede/variants/wheelie/overridetree.cb: https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/deded… PS6, Line 1: chip soc/intel/jasperlake

...

Define this as well, so that the I2C rise, hold and fall times can be tuned later. […]

Done -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 7 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 23 Apr 2020 06:38:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marco Chen <marcochen(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

Marco Chen (Code Review)

10:14 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: add new variant for wheelie

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/dedede: add new variant for wheelie ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 7 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 23 Apr 2020 15:14:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

10:37 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: add new variant for wheelie

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/dedede: add new variant for wheelie ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 7 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 23 Apr 2020 15:37:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1 May 1 May

1:10 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: add new variant for wheelie

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/dedede: add new variant for wheelie ...................................................................... mb/google/dedede: add new variant for wheelie Add initial support for wheelie variant board. BUG=b:154664137 BRANCH=None TEST=build Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Signed-off-by: peichao.wang <peichao.wang(a)bitland.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/40587 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Marco Chen <marcochen(a)google.com> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/wheelie/Makefile.inc A src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h A src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h A src/mainboard/google/dedede/variants/wheelie/overridetree.cb 6 files changed, 81 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 1aabd05..3743908 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -55,6 +55,7 @@ default "Dedede" if BOARD_GOOGLE_DEDEDE default "Waddledoo" if BOARD_GOOGLE_WADDLEDOO default "Waddledee" if BOARD_GOOGLE_WADDLEDEE + default "Wheelie" if BOARD_GOOGLE_WHEELIE config MAX_CPUS int @@ -77,5 +78,6 @@ default "dedede" if BOARD_GOOGLE_DEDEDE default "waddledoo" if BOARD_GOOGLE_WADDLEDOO default "waddledee" if BOARD_GOOGLE_WADDLEDEE + default "wheelie" if BOARD_GOOGLE_WHEELIE endif #BOARD_GOOGLE_BASEBOARD_DEDEDE diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index 36c2467..cf9298c 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -17,3 +17,9 @@ select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP select BOARD_ROMSIZE_KB_32768 + +config BOARD_GOOGLE_WHEELIE + bool "Wheelie" + select BOARD_GOOGLE_BASEBOARD_DEDEDE + select BASEBOARD_DEDEDE_LAPTOP + select BOARD_ROMSIZE_KB_32768 diff --git a/src/mainboard/google/dedede/variants/wheelie/Makefile.inc b/src/mainboard/google/dedede/variants/wheelie/Makefile.inc new file mode 100644 index 0000000..13afb36 --- /dev/null +++ b/src/mainboard/google/dedede/variants/wheelie/Makefile.inc @@ -0,0 +1,8 @@ +## +## This file is part of the coreboot project. +## +## +## SPDX-License-Identifier: GPL-2.0-or-later +## + +SPD_SOURCES = Micron_MT53E512M32D2NP_2GB #0b0000 diff --git a/src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h b/src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h new file mode 100644 index 0000000..70bd8e7 --- /dev/null +++ b/src/mainboard/google/dedede/variants/wheelie/include/variant/ec.h @@ -0,0 +1,13 @@ +/* + * This file is part of the coreboot project. + * + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef MAINBOARD_EC_H +#define MAINBOARD_EC_H + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h b/src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h new file mode 100644 index 0000000..fd92743 --- /dev/null +++ b/src/mainboard/google/dedede/variants/wheelie/include/variant/gpio.h @@ -0,0 +1,13 @@ +/* + * This file is part of the coreboot project. + * + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef MAINBOARD_GPIO_H +#define MAINBOARD_GPIO_H + +#include <baseboard/gpio.h> + +#endif /* MAINBOARD_GPIO_H */ diff --git a/src/mainboard/google/dedede/variants/wheelie/overridetree.cb b/src/mainboard/google/dedede/variants/wheelie/overridetree.cb new file mode 100644 index 0000000..1e75864 --- /dev/null +++ b/src/mainboard/google/dedede/variants/wheelie/overridetree.cb @@ -0,0 +1,39 @@ +chip soc/intel/jasperlake + + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| I2C0 | Trackpad | + #| I2C1 | Digitizer | + #| I2C2 | Touchscreen | + #| I2C3 | Camera | + #| I2C4 | Audio | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[1] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[3] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[4] = { + .speed = I2C_SPEED_FAST, + }, + }" + device domain 0 on end +end -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 8 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Magf - <magf(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: merged

449

days inactive

458

days old

coreboot-gerrit@coreboot.org

Manage subscription

23 comments

4 participants

tags (0)

participants (4)

Karthik Ramasubramanian (Code Review)
Marco Chen (Code Review)
Patrick Georgi (Code Review)
Peichao Li (Code Review)