Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40587 ) Change subject: mb/google/wheelie: add new variant for wheelie ...................................................................... Patch Set 6: (3 comments) https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG@7 PS6, Line 7: wheelie dedede https://review.coreboot.org/c/coreboot/+/40587/6//COMMIT_MSG@15 PS6, Line 15: Signed-off-by: peichao.wang <peichao.wang@bitland.corp-partner.google.com> Nit: Move it after Change-Id line. https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/wheelie/overridetree.cb: https://review.coreboot.org/c/coreboot/+/40587/6/src/mainboard/google/dedede... PS6, Line 1: chip soc/intel/jasperlake Define this as well, so that the I2C rise, hold and fall times can be tuned later. # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | #+-------------------+---------------------------+ #| GSPI0 | cr50 TPM. Early init is | #| | required to set up a BAR | #| | for TPM communication | #| | before memory is up | #| I2C0 | Trackpad | #| I2C1 | Digitizer | #| I2C2 | Touchscreen | #| I2C3 | Camera | #| I2C4 | Audio | #+-------------------+---------------------------+ register "common_soc_config" = "{ .gspi[0] = { .speed_mhz = 1, .early_init = 1, }, .i2c[0] = { .speed = I2C_SPEED_FAST, }, .i2c[1] = { .speed = I2C_SPEED_FAST, }, .i2c[2] = { .speed = I2C_SPEED_FAST, }, .i2c[3] = { .speed = I2C_SPEED_FAST, }, .i2c[4] = { .speed = I2C_SPEED_FAST, }, }" -- To view, visit https://review.coreboot.org/c/coreboot/+/40587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id638e987f45c247dae824f221a38ccf32626572f Gerrit-Change-Number: 40587 Gerrit-PatchSet: 6 Gerrit-Owner: Peichao Li <peichao.wang@bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Justin TerAvest <teravest@chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Marco Chen <marcochen@google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 22 Apr 2020 19:21:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment