build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39658 )
Change subject: [WIP] mb/asrock/q1900m: Add new mainboard ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39658/11/src/mainboard/asrock/q1900... File src/mainboard/asrock/q1900m/gpio.c:
https://review.coreboot.org/c/coreboot/+/39658/11/src/mainboard/asrock/q1900... PS11, Line 114: [55] = GPIO_FS, // BD12 - PF_PRES# (HDA FRONT PANEL PRESENCE - PIN 4) 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/39658/11/src/mainboard/asrock/q1900... File src/mainboard/asrock/q1900m/irqroute.h:
https://review.coreboot.org/c/coreboot/+/39658/11/src/mainboard/asrock/q1900... PS11, Line 7: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39658/11/src/mainboard/asrock/q1900... PS11, Line 23: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses