build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31027 )
Change subject: nb/intel/i945: Use macro instead of magic number ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/31027/1/src/northbridge/intel/i945/early_ini... File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/#/c/31027/1/src/northbridge/intel/i945/early_ini... PS1, Line 163: pci_write_config8(PCI_DEV(0, 0x1f, 0), ACPI_CNTL, 0x80); /* ACPI_CNTL: Enable ACPI BAR */ line over 80 characters
https://review.coreboot.org/#/c/31027/1/src/northbridge/intel/i945/early_ini... PS1, Line 166: pci_write_config8(PCI_DEV(0, 0x1f, 0), GPIO_CNTL, 0x10); /* GC: Enable GPIOs */ line over 80 characters
https://review.coreboot.org/#/c/31027/1/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/31027/1/src/northbridge/intel/i945/raminit.c... PS1, Line 255: pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8); line over 80 characters
https://review.coreboot.org/#/c/31027/1/src/northbridge/intel/i945/raminit.c... PS1, Line 263: pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8); line over 80 characters