Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38706 )
Change subject: security/vboot: relocate vb2ex_abort and vb2ex_printf ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38706/4/src/security/vboot/vboot_co... File src/security/vboot/vboot_common.c:
https://review.coreboot.org/c/coreboot/+/38706/4/src/security/vboot/vboot_co... PS4, Line 29: #if CONFIG(VBOOT)
Oh. Because of the different definitions and guards. I see. […]
Well, then this is probably just not the right file to add this? Maybe just make a new one (vboot_lib.c or whatever) for these for now and make it conditional on CONFIG_VBOOT_LIB. I agree that we should still do more consolidation and clarification of what belongs where at some point, but can leave that to a later patch. I think I'd rather have too many files in the short term than random #ifdefs spread around.