1 comment:
File src/security/vboot/vboot_common.c:
Patch Set #4, Line 29: #if CONFIG(VBOOT)
Oh. Because of the different definitions and guards. I see. […]
Well, then this is probably just not the right file to add this? Maybe just make a new one (vboot_lib.c or whatever) for these for now and make it conditional on CONFIG_VBOOT_LIB. I agree that we should still do more consolidation and clarification of what belongs where at some point, but can leave that to a later patch. I think I'd rather have too many files in the short term than random #ifdefs spread around.
To view, visit change 38706. To unsubscribe, or for help writing mail filters, visit settings.