Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )
Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT ......................................................................
Patch Set 7:
(2 comments)
Patch Set 5:
Patch Set 5:
That protectli/vault_bsw is covered by CB:41917. I can add similar override for jecht and buddy, unless those should have some select SYSTEM_TYPE_xx instead and get their preferred_pm_profile right that way.
that sounds perfectly reasonable to me, thanks
If one variant is SYSTEM_TYPE_LAPTOP, I would say SYSTEM_TYPE_DESKTOP is likely not the correct one for the other variants, assuming they have battery.
Similarly, advertising PM_MOBILE for a unit that does have a battery seems wrong.
Duncan? Any ideas
https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG@7 PS6, Line 7: soc/intel/baytrail,braswell,broadwell,quark:
Maybe splitting this into platforms would result in easier-to-digest commits
I don't think it would make much difference.
https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG@10 PS6, Line 10: PM_PROFILE
PM_MOBILE
Done