Attention is currently required from: Felix Singer.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/parrot/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49199/comment/88a3744b_89e24ff0
PS1, Line 39: mainboard_smi_gpi
I have some related works. TBH I think these printk's are redundant with logging in sb/smihandler.c.
CB:49249 but I don't mind this getting merged or your works instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49199
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I151560cd5a135e00f494eda3f9d3b592ee9d984a
Gerrit-Change-Number: 49199
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Sat, 09 Jan 2021 13:59:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment