Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34548 )
Change subject: cpu,mb,soc: Init missing lb_serial struct fields ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34548/3/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/34548/3/src/lib/coreboot_table.c@12... PS3, Line 121: serial->uart_pci_addr = CONFIG_UART_PCI_ADDR; The value of this field cannot be always determined build-time since it includes PCI bus number. So I am looking at having to revert this line in case UART is not an integrated PCI device on bus zero.
See CB:14609. I don't really care that much how broken this is, marking resolved.
https://review.coreboot.org/c/coreboot/+/34548/3/src/lib/coreboot_table.c@52... PS3, Line 529: uart_fill_lb(head); You could prepare uart_fill_lb() the space they need here already.
struct lb_serial serial; memset(&serial, 0, sizeof(serial)); uart_fill_lb(&serial, head);
https://review.coreboot.org/c/coreboot/+/34548/3/src/soc/mediatek/common/uar... File src/soc/mediatek/common/uart.c:
https://review.coreboot.org/c/coreboot/+/34548/3/src/soc/mediatek/common/uar... PS3, Line 184: serial.input_hertz = uart_platform_refclk(); duplicate input_hertz