3 comments:
File src/lib/coreboot_table.c:
Patch Set #3, Line 121: serial->uart_pci_addr = CONFIG_UART_PCI_ADDR;
The value of this field cannot be always determined build-time since it includes PCI bus number. So I am looking at having to revert this line in case UART is not an integrated PCI device on bus zero.
See CB:14609. I don't really care that much how broken this is, marking resolved.
Patch Set #3, Line 529: uart_fill_lb(head);
You could prepare uart_fill_lb() the space they need here already.
struct lb_serial serial;
memset(&serial, 0, sizeof(serial));
uart_fill_lb(&serial, head);
File src/soc/mediatek/common/uart.c:
Patch Set #3, Line 184: serial.input_hertz = uart_platform_refclk();
duplicate input_hertz
To view, visit change 34548. To unsubscribe, or for help writing mail filters, visit settings.