Attention is currently required from: Hung-Te Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79990?usp=email )
Change subject: soc/mediatek: Add EARLY_INIT_MMU kconfig option ......................................................................
Patch Set 1:
(3 comments)
File src/soc/mediatek/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/79990/comment/e1eb5e9b_1304f9d9 : PS1, Line 94: EARLY_INIT_MMU How about `EARLY_MMU_INIT`?
https://review.coreboot.org/c/coreboot/+/79990/comment/13f8b4d8_f96f3950 : PS1, Line 98: When this opiton is enabled, `mtk_mmu_init()` will be done in
`'opiton' may be misspelled - perhaps 'option'?`
Please fix.
File src/soc/mediatek/mt8188/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79990/comment/fd17b292_d1282021 : PS1, Line 13: bootblock-$(CONFIG_EARLY_INIT_MMU) += ../common/bootblock.c This reads a bit weird to me, as common/bootblock.c may not be directly related to `mtk_mmu_init`. It may contain more init functions.
Can we always add it here, and then add `if (CONFIG(...))` in `bootblock_soc_early_init()`?