Attention is currently required from: Hung-Te Lin, Yidi Lin.
3 comments:
File src/soc/mediatek/common/Kconfig:
Patch Set #1, Line 94: EARLY_INIT_MMU
How about `EARLY_MMU_INIT`?
Patch Set #1, Line 98: When this opiton is enabled, `mtk_mmu_init()` will be done in
`'opiton' may be misspelled - perhaps 'option'?`
Please fix.
File src/soc/mediatek/mt8188/Makefile.inc:
Patch Set #1, Line 13: bootblock-$(CONFIG_EARLY_INIT_MMU) += ../common/bootblock.c
This reads a bit weird to me, as common/bootblock.c may not be directly related to `mtk_mmu_init`. It may contain more init functions.
Can we always add it here, and then add `if (CONFIG(...))` in `bootblock_soc_early_init()`?
To view, visit change 79990. To unsubscribe, or for help writing mail filters, visit settings.