Attention is currently required from: Brandon Weeks, Joel Linn, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81595?usp=email )
Change subject: mb/cwwk: Add CWWK CW-ADL-4L-V2.0 board ......................................................................
Patch Set 4:
(10 comments)
File src/mainboard/cwwk/Kconfig:
PS4: Add missing SPDX license identifier.
File src/mainboard/cwwk/Kconfig.name:
PS4: Add missing SPDX license identifier.
File src/mainboard/cwwk/adl/Kconfig:
PS4: Missing SPDX license identifier.
https://review.coreboot.org/c/coreboot/+/81595/comment/d93bf7ca_6babec45 : PS4, Line 19: config DEVICETREE : default "devicetree.cb" This is the default, please remove.
https://review.coreboot.org/c/coreboot/+/81595/comment/4745e4a6_b9c87e0d : PS4, Line 25: config DIMM_SPD_SIZE : default 512 : That's superfluous soon. I'm moving this to SoC code. See CB:82115.
File src/mainboard/cwwk/adl/Kconfig.name:
PS4: Missing SPDX license identifier.
File src/mainboard/cwwk/adl/Makefile.inc:
PS4: We have changed the types of Makefiles to .mk. So please rename
File src/mainboard/cwwk/adl/board.fmd:
PS4: Looks pretty much standard. Any reason for this custom flashmap?
File src/mainboard/cwwk/adl/devicetree.cb:
PS4: Please use tabs instead of spaces for indentation.
File src/mainboard/cwwk/adl/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/81595/comment/e4be1fa3_e11efe45 : PS4, Line 22: [0] = { : .addr_dimm[0] = 0x50, : }, : [1] = { : .addr_dimm[0] = 0x52, : }, How about:
``` [0] = { .addr_dimm[0] = 0x50, }, [1] = { .addr_dimm[0] = 0x52, }, ```