Attention is currently required from: Brandon Weeks, Joel Linn, Paul Menzel.
10 comments:
File src/mainboard/cwwk/Kconfig:
Add missing SPDX license identifier.
File src/mainboard/cwwk/Kconfig.name:
Add missing SPDX license identifier.
File src/mainboard/cwwk/adl/Kconfig:
Missing SPDX license identifier.
config DEVICETREE
default "devicetree.cb"
This is the default, please remove.
config DIMM_SPD_SIZE
default 512
That's superfluous soon. I'm moving this to SoC code. See CB:82115.
File src/mainboard/cwwk/adl/Kconfig.name:
Missing SPDX license identifier.
File src/mainboard/cwwk/adl/Makefile.inc:
We have changed the types of Makefiles to .mk. So please rename
File src/mainboard/cwwk/adl/board.fmd:
Looks pretty much standard. Any reason for this custom flashmap?
File src/mainboard/cwwk/adl/devicetree.cb:
Please use tabs instead of spaces for indentation.
File src/mainboard/cwwk/adl/romstage_fsp_params.c:
[0] = {
.addr_dimm[0] = 0x50,
},
[1] = {
.addr_dimm[0] = 0x52,
},
How about:
```
[0] = { .addr_dimm[0] = 0x50, },
[1] = { .addr_dimm[0] = 0x52, },
```
To view, visit change 81595. To unsubscribe, or for help writing mail filters, visit settings.