Matthew Garrett has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32531 )
Change subject: Add support for the 51nb X210 ......................................................................
Patch Set 13:
(3 comments)
Patch Set 12: Code-Review+1
(3 comments)
Please add to Documentation:
- What's working and what is not, and possible TODOs, like libgfxinit.
- How to extract EC firmware from vendor bios
- Position of flash IC and possible flash headers
- Recommend one of the external flashing methods
Docs added and other issues addressed.
https://review.coreboot.org/#/c/32531/12/src/mainboard/51nb/x210/Kconfig File src/mainboard/51nb/x210/Kconfig:
https://review.coreboot.org/#/c/32531/12/src/mainboard/51nb/x210/Kconfig@14 PS12, Line 14: select MAINBOARD_HAS_LPC_TPM
either select MAINBOARD_HAS_TPM1 or select MAINBOARD_HAS_TPM2, too
Done - removed MAINBOARD_HAS_LPC_TPM as it doesn't actually have one
https://review.coreboot.org/#/c/32531/12/src/mainboard/51nb/x210/devicetree.... File src/mainboard/51nb/x210/devicetree.cb:
https://review.coreboot.org/#/c/32531/12/src/mainboard/51nb/x210/devicetree.... PS12, Line 198: device pci 1c.3 on end # PCI Express Port 4
what's behind those PCIe ports?
Done
https://review.coreboot.org/#/c/32531/12/src/mainboard/51nb/x210/hda_verb.c File src/mainboard/51nb/x210/hda_verb.c:
https://review.coreboot.org/#/c/32531/12/src/mainboard/51nb/x210/hda_verb.c@... PS12, Line 1: #include "hda_verb.h"
no need for hda_verb. […]
Done