Patch Set 12: Code-Review+1

(3 comments)

Please add to Documentation:

• What's working and what is not, and possible TODOs, like libgfxinit.
• How to extract EC firmware from vendor bios
• Position of flash IC and possible flash headers
• Recommend one of the external flashing methods

Docs added and other issues addressed.

View Change

3 comments:

• File src/mainboard/51nb/x210/Kconfig:

  • Patch Set #12, Line 14: select MAINBOARD_HAS_LPC_TPM

    either select MAINBOARD_HAS_TPM1 or select MAINBOARD_HAS_TPM2, too

    Done - removed MAINBOARD_HAS_LPC_TPM as it doesn't actually have one

• File src/mainboard/51nb/x210/devicetree.cb:

  • Patch Set #12, Line 198: device pci 1c.3 on end # PCI Express Port 4

    what's behind those PCIe ports?

    Done

• File src/mainboard/51nb/x210/hda_verb.c:

  • Patch Set #12, Line 1: #include "hda_verb.h"

    no need for hda_verb. […]

    Done

To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.