Attention is currently required from: Nico Huber, Martin Roth, Eugene Myers, Paul Menzel, Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 196:
(13 comments)
File src/mainboard/acer/aspire_vn7_572g/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/93072138_b15d2e23 PS196, Line 22: select NO_UART_ON_SUPERIO 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/6812256b_71cf26dd PS196, Line 45: if (data_buffer <= (2017 / ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/508882ae_a7338d0f PS196, Line 300: | LPC_IOE_EC_62_66 | LPC_IOE_SUPERIO_2E_2F | LPC_IOE_EC_4E_4F" # 82h-83h 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/die.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/f948ed5b_074593ad PS196, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/b5ac3ff0_b7b35182 PS196, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/6f8f8b01_33e029da PS196, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/3d1b8e59_a54063f0 PS196, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/fc5af0b7_8b8fcfed PS196, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/8dd63997_406e0077 PS196, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/6c7da722_45c5a66d PS196, Line 98: if (dat & 1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/29b81f9c_6cfe767c PS196, Line 122: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/1ba4f2ee_a0c57351 PS196, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139311): https://review.coreboot.org/c/coreboot/+/35523/comment/59c0f785_dec577db PS196, Line 160: if (gnvs) { braces {} are not necessary for single statement blocks