Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35409 )
Change subject: arch/arm: Allow program loading of Linux kernels ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/35409/4/src/arch/arm/boot.c File src/arch/arm/boot.c:
https://review.coreboot.org/c/coreboot/+/35409/4/src/arch/arm/boot.c@19 PS4, Line 19: "eor r0, r0\n\t" nit: This is an x86ism, I think mov r0, #0 is much more readable (and the same instruction length on Arm).
https://review.coreboot.org/c/coreboot/+/35409/4/src/arch/arm/boot.c@35 PS4, Line 35: * Switch to arm instruction set. We might be running in thumb2 mode. nit: technically could just do a blx r3 and that will automatically jump back to Arm mode (because bit 0 in r3 would be 0), but maybe being more explicit is good too.