Patch set 4:Code-Review +2
2 comments:
Patch Set #4, Line 19: "eor r0, r0\n\t"
nit: This is an x86ism, I think mov r0, #0 is much more readable (and the same instruction length on Arm).
Patch Set #4, Line 35: * Switch to arm instruction set. We might be running in thumb2 mode.
nit: technically could just do a blx r3 and that will automatically jump back to Arm mode (because bit 0 in r3 would be 0), but maybe being more explicit is good too.
To view, visit change 35409. To unsubscribe, or for help writing mail filters, visit settings.