24 Nov
2020
24 Nov
'20
2:26 a.m.
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44750 )
Change subject: ec/hp/kbc1126: Wait a longer time after the first command ......................................................................
Patch Set 2:
From my testing on my ProBook 640 G1 (which is using an MEC1322 EC but with the same EC interface), I suggest setting a bigger timeout (I'd like to change it from 0x7ff to 0x10000) in send_kbd_command() and send_kbd_data(), because it can still fail after the first command.
--
To view, visit https://review.coreboot.org/c/coreboot/+/44750
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8623af75c062d6aa69d4412e0627d426c69019fb
Gerrit-Change-Number: 44750
Gerrit-PatchSet: 2
Gerrit-Owner: Pablo Stebler pablo@stebler.xyz
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Nov 2020 02:26:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment