31 Aug
2020
31 Aug
'20
1:38 p.m.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39658 )
Change subject: mb/asrock/q1900m: Add new mainboard ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39658/16/src/mainboard/asrock/q1900... File src/mainboard/asrock/q1900m/fadt.c:
https://review.coreboot.org/c/coreboot/+/39658/16/src/mainboard/asrock/q1900... PS16, Line 7: acpi_create_fadt Please, why don't you use the one we already have here: src/acpi/acpi.c ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39658
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id029074e4231db231a68bc92a4210dc052bba1c9
Gerrit-Change-Number: 39658
Gerrit-PatchSet: 16
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 31 Aug 2020 11:38:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment