Attention is currently required from: Nico Huber, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49199/comment/4f5dcce8_ab934c59 PS1, Line 9: use the __func__ : constant to fix linter issues
Please don't do it for the linter. […]
Yes, you are right. Adjusted the commit message so that it doesn't sound wrong.
File src/mainboard/google/parrot/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49199/comment/423c6329_72a6ce84 PS1, Line 21: printk(BIOS_DEBUG, "%s: %x\n", __func__, src);
You've deleted the `src` part
Done
https://review.coreboot.org/c/coreboot/+/49199/comment/966c2ee5_5d4d54bb PS1, Line 39: mainboard_smi_gpi
another case
Done