[coreboot-gerrit] Change in coreboot[master]: pciexp: Add support for allocating PCI express hotplug resources

[Jeremy Soller (Code Review)]

Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 )

Change subject: pciexp: Add support for allocating PCI express hotplug resources
......................................................................

Patch Set 3:

(1 comment)
> Patch Set 3:
>
> @Jeremy any update on this CL? I would like to see the usb4 support and additional patches like this one getting merged

I will see about addressing the comments today.

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c 
File src/device/pciexp_device.c:

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c@... 
PS2, Line 488: 	resource->gran = 22;
> I believe both .align and .gran need to conform with the requirements of the configurable .size.

I'm not sure this needs to be anything other than page aligned. I could also round the size to page aligned.