Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 ) Change subject: pciexp: Add support for allocating PCI express hotplug resources ...................................................................... Patch Set 3: (1 comment)
Patch Set 3:
@Jeremy any update on this CL? I would like to see the usb4 support and additional patches like this one getting merged
I will see about addressing the comments today. https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c File src/device/pciexp_device.c: https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c@... PS2, Line 488: resource->gran = 22;
I believe both .align and .gran need to conform with the requirements of the configurable .size. I'm not sure this needs to be anything other than page aligned. I could also round the size to page aligned.
-- To view, visit https://review.coreboot.org/c/coreboot/+/35946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc Gerrit-Change-Number: 35946 Gerrit-PatchSet: 3 Gerrit-Owner: Jeremy Soller <jeremy@system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy@system76.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> Gerrit-CC: Brandon Breitenstein <brandon.breitenstein@intel.com> Gerrit-CC: Divya S Sasidharan <divya.s.sasidharan@intel.com> Gerrit-CC: Duncan Laurie <dlaurie@chromium.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier@gmail.com> Gerrit-CC: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-CC: Mimoja <coreboot@mimoja.de> Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone@intel.com> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-CC: Subrata Banik <subrata.banik@intel.com> Gerrit-Comment-Date: Thu, 26 Dec 2019 14:47:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-MessageType: comment