[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/skylake: Add a new desktop i5 CPU

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31601 )

Change subject: soc/intel/skylake: Add a new desktop i5 CPU
......................................................................

Patch Set 3:

(1 comment)
> Patch Set 2: Code-Review+1
>
> The Intel i7-6700 seems to have the same IDs.
>
> Unrelated, strange that inteltool uses different macro names.
> util/inteltool/inteltool.h:#define PCI_DEVICE_ID_INTEL_CORE_6TH_GEN_D   0x191f /* Skylake (Desktop) */

"0x191f" is deviceID of Host Bridge for Skylake desktop processors:

lspci:
00:00.0 Host bridge [0600]: Intel Corporation Sky Lake Host Bridge/DRAM Registers [8086:191f] (rev 07)

I think the title "Add a new desktop i5 CPU" is wrong.
It would be better to rename the commit title

https://review.coreboot.org/#/c/31601/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31601/2//COMMIT_MSG@16 
PS2, Line 16: decktop
> desktop

Done